HDDS-14472. [STS] Refactor constants and validation methods to shared location #9658
+242
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmorg-git
force-pushed
the
HDDS-14472
branch
2 times, most recently
from
f54a718 to
b17e2b9
Compare
update unit tests
sodonnel
reviewed
Jan 30, 2026
| final int roleSessionNameLength = roleSessionName.length(); | ||
| if (roleSessionNameLength < ASSUME_ROLE_SESSION_NAME_MIN_LENGTH || | ||
| roleSessionNameLength > ASSUME_ROLE_SESSION_NAME_MAX_LENGTH) { | ||
| throw new OMException("Invalid RoleSessionName: must be " + ASSUME_ROLE_SESSION_NAME_MIN_LENGTH + "-" + |
Contributor
There was a problem hiding this comment.
Here we know the problem is that the length is outside bounds. In the loop below we know the length bounds are fine (as it passed this check), buts its checking characters. Should be adjust the error messages in both cases to make it more clear that the problem is length in this case and bad characters in the other case?
sodonnel
reviewed
Jan 30, 2026
| for (int i = 0; i < roleSessionNameLength; i++) { | ||
| final char c = roleSessionName.charAt(i); | ||
| if (!isRoleSessionNameChar(c)) { | ||
| throw new OMException("Invalid RoleSessionName: must be " + ASSUME_ROLE_SESSION_NAME_MIN_LENGTH + "-" + |
Contributor
There was a problem hiding this comment.
In this error, we have the character which is at fault, so we could add it to the error message to make it a little bit more helpful "Invalid character '" + c + "' in RoleSessionName ..... "
sodonnel
reviewed
Jan 30, 2026
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
I left a couple of minor comments, otherwise looks good.
sodonnel
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14472
How was this patch tested?
unit tests and smoke tests