HDDS-14070. set statemachine ready on election performed for follower #9671
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
Feb 1, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@sumitagrawl , thanks for working on this! Please see the comments inlined.
Comment on lines
+288
to
+293
| if (!refreshedAfterLeaderReady.get()) { | ||
| // refresh and validate safe mode rules if it can exit safe mode | ||
| // if being leader, all previous term transactions have been applied | ||
| // if other states, just refresh safe mode rules, and transaction keeps flushing from leader | ||
| // and does not depend on pending transactions. | ||
| refreshedAfterLeaderReady.set(true); |
Contributor
There was a problem hiding this comment.
This is not atomic. Use
if (refreshedAfterLeaderReady.compareAndSet(false, true)) {
Comment on lines
366
to
368
| if (currentLeaderTerm.get() == term) { | ||
| // Means all transactions before this term have been applied. | ||
| // This means after a restart, all pending transactions have been applied. | ||
| // Perform | ||
| // 1. Refresh Safemode rules state. | ||
| // 2. Start DN Rpc server. | ||
| if (!refreshedAfterLeaderReady.get()) { |
Contributor
There was a problem hiding this comment.
Similarly, it needs compareAndSet.
BTW, why refreshedAfterLeaderReady won't be set to false after set to true?
Comment on lines
+185
to
+193
| StorageContainerManager mockScmManager = mock(StorageContainerManager.class); | ||
| SCMHAManager mockScmhaManager = mock(SCMHAManager.class); | ||
| when(mockScmManager.getScmHAManager()).thenReturn(mockScmhaManager); | ||
| SCMRatisServer mockScmRatisServer = mock(SCMRatisServer.class); | ||
| when(mockScmhaManager.getRatisServer()).thenReturn(mockScmRatisServer); | ||
| SCMStateMachine mockScmStateMachine = mock(SCMStateMachine.class); | ||
| when(mockScmRatisServer.getSCMStateMachine()).thenReturn(mockScmStateMachine); | ||
| when((mockScmStateMachine.isRefreshedAfterLeaderReady())).thenReturn(true); | ||
| scmContext = new SCMContext.Builder().setSCM(mockScmManager).build(); |
Contributor
There was a problem hiding this comment.
Please don't use mock. We need to a real cluster test which test SCM changing leader multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Exit of safemode status for follower when all rules are satisfied. This is as:
This change in reference to below point in JIRA HDDS-5263:
But once the SCM Ratis server started it will replay logs from Transactioninfo last applied Index, so after that I see all pipelines are removed. (might be due to close pipeline)So this have no issue for leader node once choosen during leader election. And for follower node, no need follow same restriction as dynamically the pipeline can be closed on runtime and same can be created by leader continuously.
This check is present during startup to ensure SCM is writable and allow time to create pipeline as best effort and its not true always for the case of pipeline closure later on due to system unhealthy or other reason (System never moves back to Safemode later on as current behavior for any dynamic change later on).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14070
How was this patch tested?