feat: add data_converter_utils, field_type_utils, file_type and decim…#38
Merged
Conversation
leaves12138
requested changes
Jun 2, 2026
Contributor
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Thanks for the migration. I found one blocker in DataConverterUtils: non-legacy partition string conversion for negative FLOAT/DOUBLE values uses scientific notation because the fixed-format branch only accepts positive values. This breaks round-trip/path compatibility for negative floating partition values.
leaves12138
approved these changes
Jun 4, 2026
Contributor
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Re-reviewed PR #38. Given the current scope does not support FLOAT/DOUBLE as partition fields, the removal of that conversion path is acceptable. I did not find other blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce utility classes for data type conversion, field type introspection, file type classification, and decimal operations.
Changes
DataConverterUtils: Provides bidirectional converters between string values andBinaryRowfieldsFieldTypeUtils: Utility forFieldType, e.g., integer type checking, scale comparisonFileType: Enum class defining file types:kMeta,kData,kBucketIndex,kGlobalIndex,kFileIndex.DecimalUtils: validates Arrow decimal type constraintsTests
DataConverterUtilsTestFieldTypeUtilsTestFileTypeTestDecimalUtilsTest