feat(datafusion): Add $options system table#240
Open
plusplusjiajia wants to merge 3 commits intoapache:mainfrom
Open
feat(datafusion): Add $options system table#240plusplusjiajia wants to merge 3 commits intoapache:mainfrom
plusplusjiajia wants to merge 3 commits intoapache:mainfrom
Conversation
JingsongLi
reviewed
Apr 13, 2026
| _filters: &[Expr], | ||
| _limit: Option<usize>, | ||
| ) -> DFResult<Arc<dyn ExecutionPlan>> { | ||
| // Re-read latest schema each scan so in-place schema evolution is visible (Java parity). |
Contributor
There was a problem hiding this comment.
In-place? Rust has no cache, so you can just get schema from Table.
Member
Author
There was a problem hiding this comment.
In-place? Rust has no cache, so you can just get schema from Table.
Thanks for catching this! Now scan() reads self.table.schema().options() directly.
JingsongLi
reviewed
Apr 13, 2026
| /// found"). When the system name is registered but the base table is | ||
| /// missing, an explicit error is returned so users can tell the two cases | ||
| /// apart in error messages. | ||
| async fn load_system_table( |
Contributor
There was a problem hiding this comment.
Put these methods to system_tables/mod.
Member
Author
There was a problem hiding this comment.
Put these methods to system_tables/mod.
Thanks for the suggestion! Moved.
JingsongLi
reviewed
Apr 13, 2026
| async fn table(&self, name: &str) -> DFResult<Option<Arc<dyn TableProvider>>> { | ||
| let (base, system_name) = split_object_name(name); | ||
| if let Some(system_name) = system_name { | ||
| return self.load_system_table(base, system_name).await; |
Contributor
There was a problem hiding this comment.
You can create a wrap_to_system_table method to return table.
Member
Author
There was a problem hiding this comment.
You can create a wrap_to_system_table method to return table.
Good point!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the
<table>$optionsPaimon system table to the DataFusion integration, mirroring JavaOptionsTable.