-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[python] Support BlobView feature #8021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
78f1de5
[python] Support blob view fields
leaves12138 48898be
[python] Refine blob view lookup
leaves12138 6f7e030
[python] Stabilize concurrent update test
leaves12138 685df03
proto
f9f3f69
simplify
c83af95
prescan
b381efa
fix
8f4de76
fix
69dda25
refine
aa1e5ac
fmt
cbb9d59
fix
445685a
rm
bdc7709
fix
2806d14
fmt
0c4c30c
fix
54a4b50
fix
ba52973
fix
b68a8d3
support blob-view.resolve.enabled and null blob value
8cebea0
remove redundant code
8e5d909
fix
951ada1
from bytes supports BlobView
bcc3d84
fix
b2bfbfa
rebase
bebcbb3
fix
5c96d43
fix
fa6f3b9
fix
9e03fce
schema
5a4e5cc
fix
75f246b
schemaCheck
9f1f717
fix
b3de6f8
supportLimit
e6fcb79
fmt
9332f4d
fix
0271e90
fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] This prescan exhausts the prescan reader before the first main batch is returned. In Python,
limitis enforced by outerTableReadafter a batch is returned or sliced, andDataEvolutionSplitReaditself never receives that limit. Java wirestopN/limitinto the prescan reader inDataEvolutionTableRead.configureBlobViewPrescanRead. As a result, Pythonwith_limit(1)can still prescan and validate every laterBlobViewStructin the same split, and can even fail on a bad reference that the user-visible result would never return. Please pass limit/topN into the prescan scope, or at least add a blob-view + limit test to lock down the intended behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In pypaimon, currently, the limit pushdown in the Read stage of the Append table is not supported. I will support this function in the next pr