Skip to content

[Table] Fix copyWithLatestSchema option drop after table was opened #8026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnavBalyan wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −3
Open

[Table] Fix copyWithLatestSchema option drop after table was opened #8026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,10 @@ protected FileStoreTable copyInternal(
public FileStoreTable copyWithLatestSchema() {
Optional<TableSchema> optionalLatestSchema = schemaManager().latest();
if (optionalLatestSchema.isPresent()) {
Map<String, String> options = tableSchema.options();
TableSchema newTableSchema = optionalLatestSchema.get();
newTableSchema = newTableSchema.copy(options);
TableSchema latestSchema = optionalLatestSchema.get();
Map<String, String> mergedOptions = new HashMap<>(latestSchema.options());
mergedOptions.putAll(tableSchema.options());
TableSchema newTableSchema = latestSchema.copy(mergedOptions);
SchemaValidation.validateTableSchema(newTableSchema);
return copy(newTableSchema);
} else {
Expand Down
11 changes: 11 additions & 0 deletions paimon-core/src/test/java/org/apache/paimon/table/SimpleTableTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,17 @@ public void testCopyWithLatestSchema() throws Exception {
"1|40|400|binary|varbinary|mapKey:mapVal|multiset|4000"));
}

@Test
public void testCopyWithLatestSchemaPicksUpAlteredOptions() throws Exception {
FileStoreTable table = createFileStoreTable();
SchemaManager schemaManager = new SchemaManager(table.fileIO(), table.location());

schemaManager.commitChanges(SchemaChange.setOption("my-custom-key", "my-custom-value"));

FileStoreTable updated = table.copyWithLatestSchema();
assertThat(updated.schema().options()).containsEntry("my-custom-key", "my-custom-value");
}

@Test
public void testConsumerIdNotBlank() throws Exception {
FileStoreTable table =
Expand Down