[python] Align ExternalPathProvider with Java multi-strategy support.#8104
Open
zhoulii wants to merge 3 commits into
Open
[python] Align ExternalPathProvider with Java multi-strategy support.#8104zhoulii wants to merge 3 commits into
zhoulii wants to merge 3 commits into
Conversation
JingsongLi
reviewed
Jun 3, 2026
| value = self.options.get(CoreOptions.DATA_FILE_EXTERNAL_PATHS_WEIGHTS, default) | ||
| if not value: | ||
| return None | ||
| return [int(w.strip()) for w in value.split(",") if w.strip()] |
Contributor
There was a problem hiding this comment.
Please validate the parsed weights here, matching Java CoreOptions.externalPathWeights(). Currently zero or negative weights are accepted and then WeightedExternalPathProvider builds invalid cumulative weights: for example 0,0 makes total_weight zero so every random value maps past the last cumulative entry and all files go to the last path, while 10,-5 makes the second path unreachable. Java rejects non-positive weights, so Python should raise for <= 0 too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
close #8103
Tests