Modernize query planner: use Object.values instead of manual mapping#9174
Open
MOHITKOURAV01 wants to merge 1 commit intoapache:masterfrom
Open
Modernize query planner: use Object.values instead of manual mapping#9174MOHITKOURAV01 wants to merge 1 commit intoapache:masterfrom
MOHITKOURAV01 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize Query Planner: Replace manual mapping with
Object.valuesThis PR modernizes the
shouldShortCircuitfunction in thepouchdb-findquery planner. It resolves a legacy@todocomment by replacing a manual iteration overObject.keyswith the nativeObject.values()method.Rationale
Object.values()is more concise and directly expresses the intent of gathering all selector values.Object.values()in other core modules, making this change consistent with current project standards.Changes
@todoregarding Node.js v6 support.shouldShortCircuitto useObject.values(selector).Testing Conducted
npm run test-unit(164/164 passing).findtests usingTYPE=find ADAPTERS=memory(349/349 passing).npm run build.