-
Notifications
You must be signed in to change notification settings - Fork 8
Distributed RPC framework implemented by the Pulsar client #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| <!-- | ||
| RULES | ||
| * Never place a link to an external site like Google Doc. The proposal should be in this issue entirely. | ||
| * Use a spelling and grammar checker tools if available for you (there are plenty of free ones). | ||
|
|
||
| PROPOSAL HEALTH CHECK | ||
| I can read the design document and understand the problem statement and what you plan to change *without* resorting to a couple of hours of code reading just to start having a high level understanding of the change. | ||
|
|
||
| IMAGES | ||
| If you need the diagrams, please create a folder named pcip-XXX under the pcip/static/img path and put the images in it. | ||
|
|
||
| THIS COMMENTS | ||
| Please remove them when done. | ||
| --> | ||
|
|
||
| # PCIP-XXX: Proposal title | ||
|
|
||
| # Background knowledge | ||
|
|
||
| <!-- | ||
| Describes all the knowledge you need to know in order to understand all the other sections in this PCIP | ||
|
|
||
| * Give a high level explanation on all concepts you will be using throughout this document. For example, if you want to talk about Persistent Subscriptions, explain briefly (1 paragraph) what this is. If you're going to talk about Transaction Buffer, explain briefly what this is. | ||
| If you're going to change something specific, then go into more detail about it and how it works. | ||
| * Provide links where possible if a person wants to dig deeper into the background information. | ||
|
|
||
| DON'T | ||
| * Do not include links *instead* explanation. Do provide links for further explanation. | ||
|
|
||
| (They also included the motivation there, but ignore it as we place that in Motivation section explicitly) | ||
| --> | ||
|
|
||
| # Motivation | ||
|
|
||
| <!-- | ||
| Describe the problem this proposal is trying to solve. | ||
|
|
||
| * Explain what is the problem you're trying to solve - current situation. | ||
| * This section is the "Why" of your proposal. | ||
| --> | ||
|
|
||
| # Goals | ||
|
|
||
| ## In Scope | ||
|
|
||
| <!-- | ||
| What this PCIP intend to achieve. Why does it benefit Pulsar. | ||
| --> | ||
|
|
||
| ## Out of Scope | ||
|
|
||
| <!-- | ||
| Describe what you have decided to keep out of scope, perhaps left for a different PCIP/s. | ||
| --> | ||
|
|
||
|
|
||
| # High Level Design | ||
|
|
||
| <!-- | ||
| Describe the design of your solution in *high level*. | ||
| Describe the solution end to end, from a birds-eye view. | ||
| Don't go into implementation details in this section. | ||
|
|
||
| I should be able to finish reading from beginning of the PCIP to here (including) and understand the feature and | ||
| how you intend to solve it, end to end. | ||
|
|
||
| DON'T | ||
| * Avoid code snippets, unless it's essential to explain your intent. | ||
| --> | ||
|
|
||
| # Detailed Design | ||
|
|
||
| ## Design & Implementation Details | ||
|
|
||
| <!-- | ||
| This is the section where you dive into the details. It can be: | ||
| * Concrete class names and their roles and responsibility, including methods. | ||
| * Code snippets of existing code. | ||
| * Interface names and its methods. | ||
| * ... | ||
| --> | ||
|
|
||
| ## Public-facing Changes | ||
|
|
||
| <!-- | ||
| Describe the additions you plan to make for each public facing component. | ||
| Remove the sections you are not changing. | ||
| Clearly mark any changes which are BREAKING backward compatability. | ||
| --> | ||
|
|
||
| ### Public API | ||
| <!-- | ||
| When adding a new endpoint to the REST API, please make sure to document the following: | ||
|
|
||
| * path | ||
| * query parameters | ||
| * HTTP body parameters, usually as JSON. | ||
| * Response codes, and for each what they mean. | ||
| For each response code, please include a detailed description of the response body JSON, specifying each field and what it means. | ||
| This is the place to document the errors. | ||
| --> | ||
|
|
||
| ### Binary protocol | ||
|
|
||
| ### Configuration | ||
|
|
||
| ### CLI | ||
|
|
||
| ### Metrics | ||
|
|
||
| <!-- | ||
| For each metric provide: | ||
| * Full name | ||
| * Description | ||
| * Attributes (labels) | ||
| * Unit | ||
| --> | ||
|
|
||
|
|
||
| # Monitoring | ||
|
|
||
| <!-- | ||
| Describe how the changes you make in this proposal should be monitored. | ||
| Don't describe the detailed metrics - they should be at "Public-facing Changes" / "Metrics" section. | ||
| Describe how the user will use the metrics to monitor the feature: Which alerts they should set up, which thresholds, ... | ||
| --> | ||
|
|
||
| # Alternatives | ||
|
|
||
| <!-- | ||
| If there are alternatives that were already considered by the authors or, after the discussion, by the community, and were rejected, please list them here along with the reason why they were rejected. | ||
| --> | ||
|
|
||
| # General Notes | ||
|
|
||
| # Links | ||
|
|
||
| <!-- | ||
| Updated afterwards | ||
| --> | ||
| * Mailing List discussion thread: | ||
| * Mailing List voting thread: | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please submit a separate PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in #9.