Skip to content

Conversation

@coderzc
Copy link
Member

@coderzc coderzc commented Dec 9, 2025

Motivation

Since broker sent ErrorResponse to client when adding schema failed, so broker side only need to print warn log to help to troubleshoot the problem.

Modifications

The log level is changed from error to warn, and the conditional check for IncompatibleSchemaException is removed, so all failures are now logged as warnings.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 9, 2025
@coderzc coderzc requested a review from poorbarcode December 11, 2025 09:34
@coderzc coderzc closed this Jan 5, 2026
@coderzc coderzc reopened this Jan 5, 2026
@coderzc coderzc merged commit b1019ce into apache:master Jan 5, 2026
117 of 123 checks passed
@coderzc coderzc added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Jan 7, 2026
@coderzc coderzc added this to the 4.2.0 milestone Jan 7, 2026
coderzc added a commit that referenced this pull request Jan 7, 2026
coderzc added a commit that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/broker cherry-picked/branch-4.0 cherry-picked/branch-4.1 doc-not-needed Your PR changes do not impact docs release/4.0.9 release/4.1.3 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants