Skip to content

[fix][test] Make ClusterMigrationTest.testClusterMigrationWithReplicationBacklog more robust#25330

Open
merlimat wants to merge 2 commits intoapache:masterfrom
merlimat:flaky-migration-test
Open

[fix][test] Make ClusterMigrationTest.testClusterMigrationWithReplicationBacklog more robust#25330
merlimat wants to merge 2 commits intoapache:masterfrom
merlimat:flaky-migration-test

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Mar 16, 2026

Summary

  • Replace retryStrategically with Awaitility.await() for better wait semantics and clearer assertion error messages on failure
  • Use generous timeouts for inherently slow operations: replicator reconnection after broker restart (60s), producer redirect with exponential backoff (90s), and broker restart/replicator setup (20-30s)
  • Use Awaitility defaults (10s) for fast operations that should complete quickly

Test plan

  • [x Run ClusterMigrationTest.testClusterMigrationWithReplicationBacklog multiple times to verify reduced flakiness

  • doc

  • doc-required

  • doc-not-needed

  • doc-complete

…tionBacklog more robust

Replace retryStrategically with Awaitility.await() for better wait
semantics and clearer assertions. Use generous timeouts for operations
that can be slow: replicator reconnection after broker restart (60s),
producer redirect with exponential backoff (90s), and broker
restart/replicator setup (20-30s).
@github-actions
Copy link

@merlimat Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 17, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.78%. Comparing base (3936ce4) to head (a54207d).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25330      +/-   ##
============================================
+ Coverage     72.25%   72.78%   +0.52%     
+ Complexity    33963     2461   -31502     
============================================
  Files          1954     1954              
  Lines        154639   154691      +52     
  Branches      17698    17700       +2     
============================================
+ Hits         111732   112585     +853     
+ Misses        33884    33067     -817     
- Partials       9023     9039      +16     
Flag Coverage Δ
inttests 25.71% <ø> (-0.08%) ⬇️
systests 22.53% <ø> (-0.02%) ⬇️
unittests 73.76% <ø> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 137 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants