[improve] PIP-467: Convert pulsar-common module logging from SLF4J to slog#25506
Merged
merlimat merged 2 commits intoapache:masterfrom Apr 10, 2026
Merged
[improve] PIP-467: Convert pulsar-common module logging from SLF4J to slog#25506merlimat merged 2 commits intoapache:masterfrom
merlimat merged 2 commits intoapache:masterfrom
Conversation
Member
|
btw. Should we also add the |
Contributor
Author
For as pure formatting change sure, though here there could potentially be bugs deriving from this commit, so it might be good to not hide them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulsar-commonfrom SLF4J to slog structured logging@Slf4jwith@CustomLogand convert log statements to slog fluent API with structured attributes.exception(e)for Throwable objects and lazy attrs where appropriateFileUtilsmethods (use class-level logger instead)Test plan
compileJavaandcompileTestJavapasscheckstyleMainandcheckstyleTestpassMotivation
PIP-467
Modifications
Convert pulsar-common module from SLF4J to slog structured logging.
Note
Please label this PR with
ready-to-test