[test][common] Harden primitive collection correctness with oracle-backed tests#26022
Open
void-ptr974 wants to merge 1 commit into
Open
[test][common] Harden primitive collection correctness with oracle-backed tests#26022void-ptr974 wants to merge 1 commit into
void-ptr974 wants to merge 1 commit into
Conversation
void-ptr974
changed the title
void-ptr974
force-pushed
the
test/collections-correctness-tests-pr
branch
from
8573556 to
7eba30c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar has several custom primitive collection implementations where correctness depends on open-addressing probe chains, collision handling, and stable ordering. The existing tests covered basic API behavior, but they did not consistently compare long operation sequences against a trusted oracle.
Modifications
HashMap,HashSet, andPriorityQueueoracles.computeIfAbsent, and reference-equality conditional removal.forEach,values, iterator, and queue head ordering as observable state checks.-Dpulsar.collections.randomSeed=<seed>.Verification
./gradlew :pulsar-common:test --tests org.apache.pulsar.common.util.collections.Long2IntOpenHashMapTest --tests org.apache.pulsar.common.util.collections.Long2ObjectOpenHashMapTest --tests org.apache.pulsar.common.util.collections.Int2ObjectOpenHashMapTest --tests org.apache.pulsar.common.util.collections.HashSetTest -PtestRetryCount=0./gradlew :pulsar-common:checkstyleTest./gradlew :pulsar-common:test --tests 'org.apache.pulsar.common.util.collections.*' -PtestRetryCount=0./gradlew :pulsar-common:test --rerun-tasks --tests org.apache.pulsar.common.util.collections.Long2IntOpenHashMapTest --tests org.apache.pulsar.common.util.collections.Long2ObjectOpenHashMapTest --tests org.apache.pulsar.common.util.collections.Int2ObjectOpenHashMapTest --tests org.apache.pulsar.common.util.collections.HashSetTest --tests org.apache.pulsar.common.util.collections.TripleLongPriorityQueueTest -PtestRetryCount=0 -Dpulsar.collections.randomSeed=123456789