RANGER-5533:Verify JWT Issuer Claims if present#901
Open
ChinmayHegde24 wants to merge 3 commits intoapache:masterfrom
Open
RANGER-5533:Verify JWT Issuer Claims if present#901ChinmayHegde24 wants to merge 3 commits intoapache:masterfrom
ChinmayHegde24 wants to merge 3 commits intoapache:masterfrom
Conversation
kumaab
reviewed
Mar 31, 2026
ranger-authn/src/main/java/org/apache/ranger/authz/handler/jwt/RangerJwtAuthHandler.java
Show resolved
Hide resolved
kumaab
reviewed
Apr 7, 2026
ranger-authn/src/main/java/org/apache/ranger/authz/handler/jwt/RangerJwtAuthHandler.java
Outdated
Show resolved
Hide resolved
kumaab
reviewed
Apr 9, 2026
ranger-authn/src/main/java/org/apache/ranger/authz/handler/jwt/RangerJwtAuthHandler.java
Outdated
Show resolved
Hide resolved
ranger-authn/src/main/java/org/apache/ranger/authz/handler/jwt/RangerJwtAuthHandler.java
Outdated
Show resolved
Hide resolved
ranger-authn/src/main/java/org/apache/ranger/authz/handler/jwt/RangerJwtAuthHandler.java
Outdated
Show resolved
Hide resolved
| verify(chain, times(0)).doFilter(any(ServletRequest.class), any(ServletResponse.class)); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
What value does this test add? A test function to test protected boolean validateIssuer(final SignedJWT jwtToken) { seems appropriate.
Contributor
Author
There was a problem hiding this comment.
Yes thank you so much @kumaab for reviewing this PR, Unit tests for validateIssuer() are not added in this PR as the ranger-authn module currently has no test coverage. This is being tracked separately under RANGER-5548
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for validating the iss (issuer) claim in JWT has been added as part of this PR.