Skip to content

RATIS-2493. Check actions with zizmor#1426

Open
adoroszlai wants to merge 8 commits intoapache:masterfrom
adoroszlai:RATIS-2493
Open

RATIS-2493. Check actions with zizmor#1426
adoroszlai wants to merge 8 commits intoapache:masterfrom
adoroszlai:RATIS-2493

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Validate GitHub Actions workflow with zizmor action
  • Fix violations
    • increase dependabot cooldown period
    • pin actions by SHA
    • do not persist credentials
    • avoid template injection (see GitHub doc, also RATIS-2373)
    • restrict permissions
    • use secrets from apache org (see INFRA-27775 for details)
    • explicitly pass specific secrets to reusable workflow instead of inheriting all secrets

https://issues.apache.org/jira/browse/RATIS-2493

How was this patch tested?

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@adoroszlai
Copy link
Copy Markdown
Contributor Author

I find this list of "deployments" in the PR a bit noisy, so we should probably suppress the secrets-outside-env check (we do not have control over our secrets, Apache Infra does). It will be configurable starting with the next release of zizmor, 1.24.0 (zizmorcore/zizmor#1750).

Copy link
Copy Markdown
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants