Skip to content

fix(acl): 修正 ipRegex 以支持 IPv4/IPv6 的 CIDR;补齐 /128 并新增 IPv4 /0–32#367

Open
azure-sea wants to merge 1 commit into
apache:masterfrom
azure-sea:fix-cidr-regex--error
Open

fix(acl): 修正 ipRegex 以支持 IPv4/IPv6 的 CIDR;补齐 /128 并新增 IPv4 /0–32#367
azure-sea wants to merge 1 commit into
apache:masterfrom
azure-sea:fix-cidr-regex--error

Conversation

@azure-sea

Copy link
Copy Markdown

原正则表达不支持ipv4/0–32与ipv6/128
例如不支持192.168.1.0/24和ipv6

What is the purpose of the change

fix #366 (comment)

Brief changelog

修复原正则表达不支持ipv4/0–32与ipv6/128表达

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

原正则表达不支持ipv4/0–32与ipv6/128
例如不支持192.168.1.0/24和ipv6

@oss-sentinel-ai oss-sentinel-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approved ✅

PR: #367 — fix(acl): 修正 ipRegex 以支持 IPv4/IPv6 的 CIDR;补齐 /128 并新增 IPv4 /0–32
Type: Bug fix (1 file, +1/-1)

Assessment

Fixes the IP regex pattern in ACL configuration to properly support IPv4 and IPv6 CIDR notation, including edge cases like /128 and /0-32.

Verdict

✅ Correct regex fix for CIDR support.


🤖 Automated review by oss-sentinel-ai

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by github-manager-bot

Summary

Fixes the IP regex in the ACL page to support IPv4 CIDR /0/32 and IPv6 CIDR /128.

Findings

  • [Info] The old regex didn't support IPv4 CIDR /0/32 (e.g., 192.168.1.0/24) or IPv6 /128.
  • [Info] The new regex correctly handles:
    • IPv4 with optional CIDR /0/32
    • IPv6 with optional CIDR /0/128
  • [Warning] The regex is very long and complex. Consider extracting it to a named constant or a validation utility for maintainability.
  • [Warning] Consider adding unit tests or at least a few test cases in the PR description to verify the regex handles edge cases (e.g., ::1, ::/0, 2001:db8::/32, 0.0.0.0/0).

Suggestions

  • Add a comment explaining the regex structure or link to a reference.
  • Consider using a library for IP validation if available in the frontend stack.

Overall: Correct fix for the reported issue.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ACL 授权Source IP不支持网段配置,例如(192.168.1.0/24)

3 participants