fix(acl): 修正 ipRegex 以支持 IPv4/IPv6 的 CIDR;补齐 /128 并新增 IPv4 /0–32#367
Open
azure-sea wants to merge 1 commit into
Open
fix(acl): 修正 ipRegex 以支持 IPv4/IPv6 的 CIDR;补齐 /128 并新增 IPv4 /0–32#367azure-sea wants to merge 1 commit into
azure-sea wants to merge 1 commit into
Conversation
原正则表达不支持ipv4/0–32与ipv6/128 例如不支持192.168.1.0/24和ipv6
oss-sentinel-ai
approved these changes
Jun 10, 2026
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #367 — fix(acl): 修正 ipRegex 以支持 IPv4/IPv6 的 CIDR;补齐 /128 并新增 IPv4 /0–32
Type: Bug fix (1 file, +1/-1)
Assessment
Fixes the IP regex pattern in ACL configuration to properly support IPv4 and IPv6 CIDR notation, including edge cases like /128 and /0-32.
Verdict
✅ Correct regex fix for CIDR support.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
reviewed
Jun 12, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Fixes the IP regex in the ACL page to support IPv4 CIDR /0–/32 and IPv6 CIDR /128.
Findings
- [Info] The old regex didn't support IPv4 CIDR
/0–/32(e.g.,192.168.1.0/24) or IPv6/128. - [Info] The new regex correctly handles:
- IPv4 with optional CIDR
/0–/32 - IPv6 with optional CIDR
/0–/128
- IPv4 with optional CIDR
- [Warning] The regex is very long and complex. Consider extracting it to a named constant or a validation utility for maintainability.
- [Warning] Consider adding unit tests or at least a few test cases in the PR description to verify the regex handles edge cases (e.g.,
::1,::/0,2001:db8::/32,0.0.0.0/0).
Suggestions
- Add a comment explaining the regex structure or link to a reference.
- Consider using a library for IP validation if available in the frontend stack.
Overall: Correct fix for the reported issue.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原正则表达不支持ipv4/0–32与ipv6/128
例如不支持192.168.1.0/24和ipv6
What is the purpose of the change
fix #366 (comment)
Brief changelog
修复原正则表达不支持ipv4/0–32与ipv6/128表达
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.