[ISSUE #10465] Preserve suspend flag when rewriting POP revive retry records

[yx9o]

• Fixes [Enhancement] Preserve suspend flag when rewriting POP revive retry records #10465 .

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.99%. Comparing base (6339431) to head (ec31424).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10466      +/-   ##
=============================================
- Coverage      48.05%   47.99%   -0.06%     
+ Complexity     13309    13291      -18     
=============================================
  Files           1377     1377              
  Lines         100632   100635       +3     
  Branches       12995    12995              
=============================================
- Hits           48362    48304      -58     
- Misses         46338    46388      +50     
- Partials        5932     5943      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[oss-sentinel-ai]

Review: Approved ✅

PR: #10466 — Preserve suspend flag when rewriting POP revive retry records
Type: Bug fix (4 files, +23/-4)

Assessment

Fixes POP messaging retry semantics:

• Copies suspend flag in backoff rewrite paths
• Preserves suspend in KV-to-FS transfer
• Prevents suspended retries from being treated as normal retries

Verdict

✅ Important correctness fix for POP messaging. Fixes #10465.

---

🤖 Automated review by oss-sentinel-ai

[RockteMQ-AI]

Review by github-manager-bot

Summary

Bug fix: preserves the suspend flag when POP revive retry records are rewritten during backoff, transfer to FS store, and CK rewrite in PopReviveService.

Findings

• [Info] PopConsumerService.revive() — Now passes record.isSuspend() to the retry record constructor. Correct fix for the data loss.
• [Info] PopConsumerService.transferToFsStore() — Adds ck.setSuspend(record.isSuspend()) to preserve the flag in checkpoint messages.
• [Info] PopReviveService.rePutCK() — Adds newCk.setSuspend(oldCK.isSuspend()) to preserve the flag during CK rewrite.
• [Info] Tests — Good coverage: verifies suspend flag through backoff retry, transfer to FS store, and CK rewrite paths.

Suggestions

• The fix is minimal and targeted. No concerns.

Overall: Clean bug fix with proper test coverage. LGTM.

---

Automated review by github-manager-bot