docs: fix dead link to tiered store config in tieredstore README#10484
Conversation
The 'Configuration' section linked to TieredMessageStoreConfig.java under the tieredstore/common package, but that class has been renamed to MessageStoreConfig and moved to the tieredstore package root, so the link returns 404. Point it at the current MessageStoreConfig.java, which holds the tiered store configuration fields documented in the table below (tieredStoreFilePath, tieredBackendServiceProvider, tieredStorageLevel, ...). Signed-off-by: fancy-agent <fancyboi66@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10484 +/- ##
=============================================
- Coverage 48.15% 48.07% -0.09%
+ Complexity 13343 13318 -25
=============================================
Files 1377 1377
Lines 100656 100656
Branches 12996 12996
=============================================
- Hits 48470 48386 -84
- Misses 46258 46331 +73
- Partials 5928 5939 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #10484 — Fix dead link to tiered store config in tieredstore README
Type: Documentation (1 file, +1/-1)
Assessment
Updates broken link: TieredMessageStoreConfig.java (404) → MessageStoreConfig.java (200). Class was renamed and moved.
Verdict
✅ Simple dead link fix.
🤖 Automated review by oss-sentinel-ai
5 participants
What
The Configuration section of
tieredstore/README.mdlinks toTieredMessageStoreConfig.javaunder thetieredstore/commonpackage. That class has since been renamed toMessageStoreConfigand moved to thetieredstorepackage root, so the link returns 404. This updates the link (and its text) to the current class.Why
.../tieredstore/common/TieredMessageStoreConfig.java.../tieredstore/MessageStoreConfig.javatieredStoreFilePath,tieredBackendServiceProvider,tieredStorageLevel,readAheadCache*, …) all live in the currentMessageStoreConfig.java, confirming it is the right target.How verified
findacross the repo: no file namedTieredMessageStoreConfig.javaexists anymore.curl -Ithe old URL → 404, the new URL → 200.tieredstore/.../MessageStoreConfig.java.Docs-only, single line, no behavior change.