Skip to content

Conversation

@Gautam-aman
Copy link

What does this PR do?

Skip invalid POP records when the consumer group does not exist, preventing
unnecessary checkpoint and retry message generation.

Why is it needed?

Currently, POP checkpoints may still be written even if the consumer group
is absent, leading to invalid retries and wasted resources.

How was this tested?

Verified locally with broker module build and full reactor build.
All quality checks (SpotBugs, Checkstyle) pass.

Related Issue

Fixes #9980

)

Signed-off-by: Aman Gautam <amangautam2128@gmail.com>
@Gautam-aman
Copy link
Author

Local build and full reactor completed successfully on JDK 17.
No functional changes outside POP broker logic.

@lizhimins
Copy link
Member

must remove flattened-pom.xml from your pr

@lizhimins lizhimins changed the title Skip invalid POP records when consumer group does not exist (#9980) [ISSUE #9980] Skip invalid POP records when consumer group does not exist (#9980) Jan 6, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.70%. Comparing base (7cc0774) to head (45cccfe).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...cketmq/broker/processor/PopBufferMergeService.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9982      +/-   ##
=============================================
- Coverage      48.84%   48.70%   -0.15%     
+ Complexity     12773    12729      -44     
=============================================
  Files           1324     1324              
  Lines          96405    96414       +9     
  Branches       12434    12436       +2     
=============================================
- Hits           47093    46962     -131     
- Misses         43571    43691     +120     
- Partials        5741     5761      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Aman Gautam <amangautam2128@gmail.com>
@Gautam-aman
Copy link
Author

Thanks for pointing this out all generated .flattened-pom.xml files have been removed from the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Skip invalid records when the group is absent in Pop

3 participants