Skip to content

[SPARK-54957][PYTHON][TEST] Remove the unnecessary sleep in streaming tests#53724

Closed
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
gaogaotiantian:remove-crazy-sleep
Closed

[SPARK-54957][PYTHON][TEST] Remove the unnecessary sleep in streaming tests#53724
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
gaogaotiantian:remove-crazy-sleep

Conversation

@gaogaotiantian
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Instead of do a fixed time wait, we try to poll results until it meets the requirement.

Why are the changes needed?

We are wasting time on this test. time.sleep(60) is totally unnecessary. I still have trouble with the other time.sleep(30) which just try to wait to see if the server crashes without traffic - but at least that has an explanation.

Does this PR introduce any user-facing change?

No

How was this patch tested?

My local setup has some issues with this specific test so I'll have to wait for the CI result.

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 8, 2026

JIRA Issue Information

=== Test SPARK-54957 ===
Summary: Accelerate test_parity_listener.py
Assignee: None
Status: Open
Affected: ["4.2.0"]


This comment was automatically generated by GitHub Actions

Copy link
Copy Markdown
Contributor

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon
Copy link
Copy Markdown
Member

Merged to master.

@gaogaotiantian gaogaotiantian deleted the remove-crazy-sleep branch March 17, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants