[SPARK-55702][SQL][FOLLOWUP] Clean up dead error code and fix flaky window filter test#54557
Closed
cloud-fan wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55702][SQL][FOLLOWUP] Clean up dead error code and fix flaky window filter test#54557cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan wants to merge 1 commit intoapache:masterfrom
Conversation
…indow filter test Follow-up to apache#54501. 1. Remove the now-unused `windowAggregateFunctionWithFilterNotSupportedError` method and its `_LEGACY_ERROR_TEMP_1030` error class, which were left behind after the filter-in-window support was added. 2. Fix the `first_value`/`last_value` window filter test that used `ORDER BY val_long` — a column with duplicate values — making the ROWS-frame result non-deterministic. Add tiebreaker columns and use NULLS LAST so the output is both stable and meaningful.
Contributor
Author
peter-toth
approved these changes
Feb 28, 2026
viirya
approved these changes
Feb 28, 2026
dongjoon-hyun
approved these changes
Feb 28, 2026
Member
|
Merged to master, thank you @cloud-fan and all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #54501. Two cleanups:
Remove dead error code: The
windowAggregateFunctionWithFilterNotSupportedErrormethod inQueryCompilationErrors.scalaand its_LEGACY_ERROR_TEMP_1030error class inerror-conditions.jsonwere left behind after [SPARK-55702][SQL] Support filter predicate in window aggregate functions #54501 removed their only call site.Fix flaky
first_value/last_valuetest: The window filter test usedORDER BY val_longwith a ROWS frame, butval_longhas duplicate values in the test data (e.g., three rows withval_long=1), makingfirst_value/last_valueresults non-deterministic. Addedvalandcateas tiebreaker columns and usedNULLS LASTso the output is both stable and meaningful (without NULLS LAST, the first matching 'a' row hasval=NULL, makingfirst_aalways NULL).Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Re-ran
SQLQueryTestSuiteforwindow.sql— all 4 tests pass across all config dimensions.Was this patch authored or co-authored using generative AI tooling?
Yes. cursor