[SPARK-56826][SQL] Skip PushVariantIntoScan for VariantGet with null-evaluating path#55826
Open
Shekharrajak wants to merge 1 commit into
Open
Conversation
Shekharrajak
force-pushed
the
SPARK-56826-pushvariantintoscan-invariants
branch
from
2c9da49 to
c77d5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add && path.eval() != null to the VariantGet case-arm guard in both collectRequestedFields and rewriteExpr in PushVariantIntoScan.
Why are the changes needed?
A VariantGet whose foldable path evaluates to null (e.g., variant_get(v, cast(null as string), 'int')) reaches PushVariantIntoScan when NullPropagation is excluded via spark.sql.optimizer.excludedRules.
Does this PR introduce any user-facing change?
No. With the default optimizer pipeline (NullPropagation enabled), VariantGet(_, Literal(null), ...) is eliminated upstream — this code path was unreachable in practice.
How was this patch tested?
New unit tests in PushVariantIntoScanV1SuiteBase
Was this patch authored or co-authored using generative AI tooling?
Yes