[SPARK-56843][BUILD] Update checkJavaVersion to ban 25.0.[0-2] properly#55840
Open
dongjoon-hyun wants to merge 1 commit into
Open
[SPARK-56843][BUILD] Update checkJavaVersion to ban 25.0.[0-2] properly#55840dongjoon-hyun wants to merge 1 commit into
checkJavaVersion to ban 25.0.[0-2] properly#55840dongjoon-hyun wants to merge 1 commit into
Conversation
dongjoon-hyun
changed the title
checkJavaVersion to ban 25.0.[0-3] properlycheckJavaVersion to ban 25.0.[0-2] properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Require Java 25.0.3 or later in
checkJavaVersionfunction when building on Java 25 in order to avoid JDK-8377811This is consistent with our documentation too.
spark/docs/index.md
Line 38 in 4242274
Why are the changes needed?
The current check only enforces
java.minimum.version=17.0.11and treats any JDK with a higher feature version as compatible, so early Java 25 updates (25.0.0/0.1/0.2) silently pass. Pinning Java 25 builds to 25.0.3+ avoids those updates without affecting Java 17/21 users.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual build with
build/sbt core/compileon Java 17.0.11 and 21.x (pass), and confirmed the new error message is thrown whencurrentVersionFeature == 25 && currentVersionUpdate < 3.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7