ci: Compact first-time contributor welcome and stop issue-link pollution#5317
ci: Compact first-time contributor welcome and stop issue-link pollution#5317Ma77Ball wants to merge 15 commits into
Conversation
stop issue-link pollution
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5317 +/- ##
============================================
- Coverage 52.38% 52.38% -0.01%
+ Complexity 2484 2480 -4
============================================
Files 1070 1070
Lines 41359 41359
Branches 4441 4441
============================================
- Hits 21666 21664 -2
+ Misses 18427 18422 -5
- Partials 1266 1273 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/request-review @Yicong-Huang |
Yicong-Huang
left a comment
There was a problem hiding this comment.
Approved with one comment inline.
|
will wait for #5244, I believe some of the commands here is describing the action in that PR. |
.txt file and exclude it from CI labeling
There was a problem hiding this comment.
Pull request overview
This PR refactors the first-time contributor welcome comment workflow to reduce noise and prevent GitHub issue auto-linking from creating unwanted cross-references, while making the message easier to edit without touching workflow logic.
Changes:
- Move the welcome message body out of
.github/workflows/welcome-first-time-contributor.ymlinto.github/welcome-first-time-contributor.txt, and load it at runtime with placeholder substitution. - Rewrite the welcome text to be shorter and wrap issue references in inline code to avoid autolink/backlink “pollution”.
- Update
.github/labeler.ymlto try to exclude wording-only edits of the template from applying thecilabel.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/welcome-first-time-contributor.yml | Adds sparse checkout of the welcome template and renders the comment body from that template at runtime. |
| .github/welcome-first-time-contributor.txt | New standalone welcome message template with placeholders and non-autolinking examples. |
| .github/labeler.yml | Attempts to exclude the welcome template from the ci label so wording-only edits can skip full CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - changed-files: | ||
| - any-glob-to-any-file: | ||
| - '.github/**' | ||
| - '.asf.yaml' | ||
| - 'codecov.yml' |
There was a problem hiding this comment.
Update the PR description as well.
|
Pr description is not accurate? I don't think we have labeler change in this PR. @Ma77Ball |
|
It did have labeled changes as shown in the Copilot comment. I removed this as the effort to avoid a full CI run will require some trade-off (either direction we take). |
I left a comment for this one already. |
What changes were proposed in this PR?
Reworks the first-time-contributor welcome comment posted by
welcome-first-time-contributor.yml.starter-taskissues for newcomers, plus clearer full-sentence guidance for the three comment-command groups (issues, sub-issues, pull requests).#5166and#5222..ymland into.github/welcome-first-time-contributor.txt, read at runtime via a sparse checkout and rendered by substituting{{author}},{{owner}}, and{{repo}}..txtfile from thecilabel inlabeler.yml, so a wording-only edit no longer maps to every build stack and skips the full CI run.The rendered message a first-time contributor now sees:
Any related issues, documentation, or discussions?
Closes: #5315
How was this PR tested?
comment-commands.ymlfor accuracy..txt, replaced the placeholders, prepended the idempotency marker) and confirmed the output matches the message above with no leftover placeholders.#Ninside inline code is not autolinked, and verified zero bare#Nremain in the message body.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF