Skip to content

test(frontend): add ConflictingFileModalContentComponent unit tests#5594

Closed
Roshan3580 wants to merge 1 commit into
apache:mainfrom
Roshan3580:test/conflicting-file-modal-content-5465
Closed

test(frontend): add ConflictingFileModalContentComponent unit tests#5594
Roshan3580 wants to merge 1 commit into
apache:mainfrom
Roshan3580:test/conflicting-file-modal-content-5465

Conversation

@Roshan3580

@Roshan3580 Roshan3580 commented Jun 9, 2026

Copy link
Copy Markdown

Purpose of the PR

Closes #5467

This PR adds frontend unit tests for RegistrationRequestModalComponent.

Summary of Changes
Added registration-request-modal.component.spec.ts
Added a test to verify the component is created successfully
Added a test to verify modal data correctly seeds name and email
Added a test to verify null modal data falls back to empty strings
Added a test to verify getValues() trims whitespace from affiliation and reason
Design Proposal

N/A — this PR only adds unit tests for existing frontend behavior.

Technical Design Diagram/Description

N/A — no production logic or UI behavior was changed.

GIFs/Screenshots

N/A — test-only change.

Testing

Executed locally:

yarn test --include='**/registration-request-modal.component.spec.ts'
yarn lint

Both completed successfully.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your first contribution to Texera, @Roshan3580!

You can drive common housekeeping tasks just by leaving a comment. Type the command on its own line.

On issues

Command What it does
/take Assign the issue to yourself (self-claim it)
/untake Remove yourself as assignee

To find unclaimed work, search is:issue is:open no:assignee — there's no "triage" label; the search filter is the triage state.

Linking sub-issues

Command Where to run it What it does
/sub-issue #12 #13 On the parent Links #12 and #13 as children of this issue
/unsub-issue #12 #13 On the parent Unlinks those children
/parent-issue #5 On the child Sets #5 as this issue's parent
/unparent-issue On the child Removes this issue's parent (auto-detected)
/unparent-issue #5 On the child Removes parent #5 explicitly

You can write references as #12 or bare 12. Cross-repo references like owner/repo#12 aren't supported and are ignored.

On pull requests (author only)

Command What it does
/request-review @user [@user ...] Request reviews from those users
/unrequest-review @user [@user ...] Cancel those review requests

You can mention teams as @org/team, and @copilot works too. Only the PR author can use these commands.

Note: Commands must match exactly — /take this won't work, only /take. Bots are ignored, and you can't self-link an issue or set an issue as its own parent.

For the full contribution flow, see CONTRIBUTING.md.

@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Jun 9, 2026
@Yicong-Huang

Copy link
Copy Markdown
Contributor

@Roshan3580 please use our PR template. Please feel free to reopen once it is ready. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for RegistrationRequestModalComponent

2 participants