Conversation
There was a problem hiding this comment.
Pull request overview
Updates CXFTestBase test utilities to modernize stream handling (JDK 11 APIs), improve config handling for pipes-based parsing, and clarify related Javadocs.
Changes:
- Replace
IOUtils.copy(...)usage withInputStream.transferTo(...)/readAllBytes(). - Refactor pipes config setup to avoid overwriting the field during intermediate merge steps.
- Add/adjust Javadoc and logging around temporary config lifecycle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Show resolved
Hide resolved
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Outdated
Show resolved
Hide resolved
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Outdated
Show resolved
Hide resolved
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Outdated
Show resolved
Hide resolved
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Show resolved
Hide resolved
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Show resolved
Hide resolved
…ver/core/CXFTestBase.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Show resolved
Hide resolved
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
Outdated
Show resolved
Hide resolved
Removed logging of config file deletion and improved formatting in CXFTestBase.java.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java:450
- In these test helpers,
Files.delete(tempFile)in afinallycan throw and mask the original failure from reading/parsing the archive, making debugging harder. Consider usingdeleteIfExistsand suppressing/logging deletion failures (similar totearDown()).
} finally {
if (tempFile != null) {
Files.delete(tempFile);
}
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java:473
- Same concern here:
Files.delete(tempFile)in thefinallyblock can override the original exception from zip processing. UsingdeleteIfExistsand suppressing/logging IOExceptions would keep the primary test failure visible.
} finally {
if (tempFile != null) {
Files.delete(tempFile);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!