Skip to content

TIKA-4727: Add experimental strongly-typed protobuf response to tika-grpc #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nddipiazza wants to merge 1 commit into
base: main
Choose a base branch
from
+1,025 −1
Draft

TIKA-4727: Add experimental strongly-typed protobuf response to tika-grpc #2811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.io.File;
import java.io.IOException;
import java.nio.file.Path;
import java.util.List;
import java.util.Map;
import java.util.Objects;

Expand Down Expand Up @@ -248,14 +249,17 @@ private void fetchAndParseImpl(FetchAndParseRequest request,
fetchReplyBuilder.setErrorMessage(pipesResult.message());
}
if (pipesResult.emitData() != null && pipesResult.emitData().getMetadataList() != null) {
for (Metadata metadata : pipesResult.emitData().getMetadataList()) {
List<Metadata> metadataList = pipesResult.emitData().getMetadataList();
for (Metadata metadata : metadataList) {
for (String name : metadata.names()) {
String value = metadata.get(name);
if (value != null) {
fetchReplyBuilder.putFields(name, value);
}
}
}
// Populate the experimental strongly-typed response alongside the flat fields map.
fetchReplyBuilder.setTypedResponse(TikaTypedMetadataMapper.map(metadataList));
}
responseObserver.onNext(fetchReplyBuilder.build());
} catch (IOException e) {
Expand Down
Loading
Loading