Keep a copy of the effective client ip for logging #12818
Merged
+5
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
approved these changes
Jan 20, 2026
cmcfarlen
added a commit
that referenced
this pull request
Jan 20, 2026
(cherry picked from commit d967264)
Contributor
Author
|
Cherry-picked to 10.1.x branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #12761:
If the transaction client vc went away before logging, then the update marshal client ip function didn't actually marshal anything and it messed up parsing the log entry later.
This fix is to just keep a copy of the effective IP for logging purposes, per tradition.