hrw4u: Fix section validations and operators #12820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
requested changes
Jan 16, 2026
tools/hrw4u/tests/test_lsp.py
Outdated
| ("REMAP", "outbound.req.", False), | ||
| ("SEND_REQUEST", "outbound.resp.", False), | ||
| ("REMAP", "outbound.req.", True), # outbound.req. is available in REMAP | ||
| ("SEND_REQUEST", "outbound.resp.", True), # outbound.resp. is available in SEND_REQUEST |
Contributor
There was a problem hiding this comment.
Is this correct? outbound.resp is available in SEND_REQUEST hook? Maybe there's a reason for this, but SEND_REQUEST hook seems to early to interact with outbound.resp.
Contributor
Author
There was a problem hiding this comment.
I think I fixed these.
zwoop
force-pushed
the
FixHrw4uTests
branch
2 times, most recently
from
0d10bb8 to
99e569f
Compare
Contributor
Author
|
[approve ci autest] |
bneradt
approved these changes
Jan 20, 2026
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. It's helpful having the validators updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.