add the NoMatcheFilter for the case that all the rows don't match #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieTien97
requested changes
Dec 16, 2025
Contributor
JackieTien97
left a comment
JackieTien97
left a comment
There was a problem hiding this comment.
Change the enum name to FALSE_LITERAL, Filter name to FalseLiteralFilter
alpass163
force-pushed
the
cyb/add_filter
branch
from
386e6c3 to
1232a47
Compare
JackieTien97
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced NoMatchFilter to handle always-false predicates. This optimization enables the engine to prune impossible conditions early, skipping unnecessary data scanning and reducing I/O overhead.