[Runtime][Builtin] Handle mismatched type on argument #0 when calling Builtin Runtime Operators#18837
Open
locnd182644 wants to merge 6 commits intoapache:mainfrom
Open
[Runtime][Builtin] Handle mismatched type on argument #0 when calling Builtin Runtime Operators#18837locnd182644 wants to merge 6 commits intoapache:mainfrom
locnd182644 wants to merge 6 commits intoapache:mainfrom
Conversation
… Builtin runtime operators. - Expected `ffi.Tensor` but got `DLTensor`
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of TVM's Builtin Runtime Operators by introducing more flexible type handling for their primary arguments. It addresses a common issue where operators expected a specific Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a type mismatch issue for vm.builtin.shape_of and vm.builtin.reshape operators by allowing them to accept DLTensor* in addition to Tensor. The change uses ffi::Any and try_cast to handle both types, which is a good approach. My main feedback is regarding a potential memory leak in the reshape implementation when handling DLTensor*, for which I've left a specific comment with a suggested fix.
locnd182644
changed the title
Contributor
Author
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/22479271221 Detailswith response |
Member
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/22498407923 Detailswith response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handle mismatched type on argument #0 when calling: Builtin Runtime Operators (ex:
vm.builtin.shape_of,vm.builtin.reshape, ...) (Expectedffi.Tensorbut gotDLTensor*)Summary
ffi.Tensorbut gotDLTensor*)Description
Tensor. But some case has argument #0 isDLTensor*.ffi.Tensorbut gotDLTensor*".Resolve
ffi:Anyto cover all cases.try_castto convert data types.TensororDLTensor*.Reference