Skip to content

[CMAKE] Remove unused Libbacktrace.cmake#18849

Merged
tlopex merged 1 commit intoapache:mainfrom
tqchen:phase-out-libbacktrace-cmake
Feb 28, 2026
Merged

[CMAKE] Remove unused Libbacktrace.cmake#18849
tlopex merged 1 commit intoapache:mainfrom
tqchen:phase-out-libbacktrace-cmake

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Feb 28, 2026

Summary

Remove legacy cmake/libs/Libbacktrace.cmake which is no longer used.
Libbacktrace is now built through tvm-ffi's own cmake infrastructure.

Libbacktrace is now built through tvm-ffi's own cmake infrastructure
(3rdparty/tvm-ffi/cmake/Utils/AddLibbacktrace.cmake). The legacy
cmake/libs/Libbacktrace.cmake is no longer referenced.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the build system by removing an obsolete CMake configuration file. The Libbacktrace.cmake file, previously responsible for building the libbacktrace library, has been deprecated because the library's build process has been successfully migrated to tvm-ffi's internal CMake setup. This change simplifies the project's build configuration and removes redundant code.

Highlights

  • Code Removal: Removed the legacy cmake/libs/Libbacktrace.cmake file, as it is no longer utilized in the build process.
  • Build System Update: The libbacktrace library is now built using tvm-ffi's dedicated CMake infrastructure, streamlining its integration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • cmake/libs/Libbacktrace.cmake
    • Removed the file as it is no longer used for building libbacktrace.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the cmake/libs/Libbacktrace.cmake file, which is described as legacy and unused. The rationale is that libbacktrace is now built through the tvm-ffi infrastructure. My review of the provided CMakeLists.txt confirms there are no references to the deleted file, supporting the claim that it is obsolete. This change represents a good cleanup of the build configuration.

@tlopex tlopex merged commit c45f72d into apache:main Feb 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants