Skip to content

[TEST] Remove stale URL mappings from request_hook#18850

Merged
tlopex merged 1 commit intoapache:mainfrom
tqchen:clean-up-request-hook-urls
Feb 28, 2026
Merged

[TEST] Remove stale URL mappings from request_hook#18850
tlopex merged 1 commit intoapache:mainfrom
tqchen:clean-up-request-hook-urls

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Feb 28, 2026

Summary

Remove 172 stale URL mappings from tests/scripts/request_hook/request_hook.py.
These entries redirected external downloads to S3 cache during CI but reference
model files for tests that no longer exist in the codebase.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining the codebase by removing a significant number of stale URL mappings. These mappings were previously used in CI to cache external model files, but the corresponding tests or models are no longer present. The change streamlines the request_hook script by only retaining active mappings, improving its relevance and reducing unnecessary overhead.

Highlights

  • Stale URL Mappings Removal: Removed 172 outdated URL mappings from tests/scripts/request_hook/request_hook.py that were used to redirect external downloads to an S3 cache during CI.
  • Code Clean-up: Eliminated an unused import statement (from urllib.parse import quote) as it was only required by the removed URL mappings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tests/scripts/request_hook/request_hook.py
    • Removed the import of urllib.parse.quote.
    • Removed 172 stale entries from the URL_MAP dictionary, leaving only one active mapping.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a large number of stale URL mappings from tests/scripts/request_hook/request_hook.py. As a result of these removals, the urllib.parse.quote import is no longer necessary and has also been removed. The changes are consistent with the goal of cleaning up test configuration. My review of the changes did not identify any issues.

@tlopex tlopex merged commit 3e5e4cf into apache:main Feb 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants