[CI] Remove stale test scripts (i386, hexagon, mypy)#18851
[CI] Remove stale test scripts (i386, hexagon, mypy)#18851tlopex merged 1 commit intoapache:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the CI process by removing several outdated and unreferenced test scripts. It specifically targets scripts related to i386 and Hexagon architectures, which are no longer supported in CI, and moves mypy checks to pre-commit hooks, resulting in a cleaner and more efficient test suite. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a good cleanup effort, removing several stale test scripts from the CI process. The changes are mostly straightforward removals of unused files and their references. However, while updating the documentation for Hexagon testing, the instructions for building inside the Docker container have become incomplete. I've added a review comment with a suggestion to fix the documentation to ensure users can still follow the build and test process for Hexagon.
b13b1a1 to
7743754
Compare
Summary
Remove 9 test scripts from
tests/scripts/that are no longer used in CI —i386 and hexagon architectures were removed from CI, mypy moved to pre-commit,
and several others are unreferenced.