Skip to content

[REFACTOR] Remove unused mscclpp contrib module#18852

Merged
tlopex merged 1 commit intoapache:mainfrom
tqchen:phase-out-mscclpp
Feb 28, 2026
Merged

[REFACTOR] Remove unused mscclpp contrib module#18852
tlopex merged 1 commit intoapache:mainfrom
tqchen:phase-out-mscclpp

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Feb 28, 2026

Summary

Remove the mscclpp (Microsoft MSCCL++) contrib module. It was added as an
experimental integration but is not used anywhere in the codebase. Removes
3rdparty headers, cmake module, runtime source, and build config options.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the project by completely removing the mscclpp contribution module. This module, initially added as an experimental integration, was determined to be unused within the codebase. Its removal simplifies the project structure by eliminating associated header files, CMake build configurations, and runtime source code, contributing to a cleaner and more maintainable system.

Highlights

  • Module Removal: Removed the mscclpp (Microsoft MSCCL++) contrib module, which was an experimental integration and found to be unused.
  • Codebase Cleanup: Eliminated all associated 3rdparty headers, CMake modules, runtime source files, and build configuration options related to mscclpp.
  • Project Simplification: Streamlined the codebase by removing unnecessary components, reducing complexity and potential maintenance overhead.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • 3rdparty/mscclpp/include/common.h
    • Removed the mscclpp common header file.
  • 3rdparty/mscclpp/include/msccl.cuh
    • Removed the mscclpp CUDA header file.
  • 3rdparty/mscclpp/include/msccl.h
    • Removed the main mscclpp public API header file.
  • CMakeLists.txt
    • Removed the USE_MSCCL build option.
    • Removed the MSCCLPP.cmake module inclusion.
  • cmake/config.cmake
    • Removed the USE_MSCCL configuration variable.
  • cmake/modules/LibInfo.cmake
    • Removed the TVM_INFO_USE_MSCCL variable from library information generation.
  • cmake/modules/contrib/MSCCLPP.cmake
    • Removed the MSCCLPP CMake module.
  • src/runtime/contrib/mscclpp/allreduce.cu
    • Removed the mscclpp allreduce CUDA implementation file.
  • src/support/libinfo.cc
    • Removed the TVM_INFO_USE_MSCCLPP preprocessor definition.
    • Removed the USE_MSCCL entry from the GetLibInfo map.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused mscclpp contrib module. The changes are comprehensive, deleting the module's source files, headers, and associated CMake build configurations. The removal is consistent across the project, with build flags and library information variables also being removed. The changes correctly remove the unused feature from the project.

@tlopex tlopex merged commit 5319c9c into apache:main Feb 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants