Skip to content

fix(generate-schema-types): change optionals to inside actor perspective #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JuanGalilea wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −5
Draft

fix(generate-schema-types): change optionals to inside actor perspective #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/lib/schema-transforms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { cloneDeep } from 'es-toolkit';

/**
* Transforms a JSON schema so that all properties without a `default` value are marked as required.
* Properties that have a `default` are left optional, since Apify fills them in at runtime.
* Transforms a JSON schema so that all properties with a `default` value are marked as required, since Apify fills them in at runtime.
* Properties that don't have a `default` are left optional.
* Recurses into nested object properties.
*/
export function makePropertiesRequired(schema: Record<string, unknown>): Record<string, unknown> {
Expand All @@ -16,10 +16,11 @@ export function makePropertiesRequired(schema: Record<string, unknown>): Record<
const requiredSet = new Set<string>(Array.isArray(clone.required) ? (clone.required as string[]) : []);

for (const [key, prop] of Object.entries(properties)) {
if (prop.default === undefined) {
if (requiredSet.has(key)) {
continue;
}
if (prop.default !== undefined) {
requiredSet.add(key);
} else {
requiredSet.delete(key);
}

if (prop.type === 'object' && prop.properties) {
Expand Down
Loading