Skip to content

tests: fix flaky tests with timing-sensitive assertions #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
Mar 19, 2026
Merged

tests: fix flaky tests with timing-sensitive assertions #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9a8ea3
fix(test): increase sleep margin in flaky recurring task test
vdusek Mar 19, 2026
7586376
fix(test): fix flaky adaptive playwright crawler timeout test
vdusek Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/unit/_utils/test_recurring_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ async def test_execution(function: AsyncMock, delay: timedelta) -> None:
task = RecurringTask(function, delay)

task.start()
await asyncio.sleep(0.1) # Wait enough for the task to execute a few times
await asyncio.sleep(0.2) # Wait enough for the task to execute a few times
await task.stop()

assert isinstance(task.func, AsyncMock) # To let type checker know that the function is a mock
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/crawlers/_adaptive_playwright/test_adaptive_playwright_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ async def test_adaptive_playwright_crawler_timeout_in_sub_crawler(test_urls: lis
request_handler_timeout = timedelta(seconds=1)

crawler = AdaptivePlaywrightCrawler.with_beautifulsoup_static_parser(
max_request_retries=1,
max_request_retries=0,
rendering_type_predictor=static_only_predictor_no_detection,
request_handler_timeout=request_handler_timeout,
)
Expand All @@ -594,8 +594,8 @@ async def request_handler(context: AdaptivePlaywrightCrawlingContext) -> None:
mocked_browser_handler()
except AdaptiveContextError:
mocked_static_handler()
# Relax timeout for the fallback browser request to avoid flakiness in test
crawler._request_handler_timeout = timedelta(seconds=10)
# Relax timeout for the fallback browser request to allow for slow browser startup on CI
crawler._request_handler_timeout = timedelta(seconds=120)
# Sleep for time obviously larger than top crawler timeout.
await asyncio.sleep(request_handler_timeout.total_seconds() * 3)

Expand Down
Loading