Open
Conversation
guoye-zhang
requested review from
FranzBusch,
czechboy0,
fabianfett,
nakulbajaj,
travarin and
xbhatnag
FranzBusch
reviewed
Mar 30, 2026
| fatalError("Waiting for a concrete HTTP server implementation") | ||
| } | ||
|
|
||
| static func proxy(server: some HTTPServer, client: some HTTPClient) async throws { |
Member
There was a problem hiding this comment.
Can we make the client inout here instead of the var further down?
Contributor
Author
There was a problem hiding this comment.
That's not possible since inout cannot be captured in an escaping closure. We do have to make a copy of the client each time to maintain exclusive access in the serve closure.
FranzBusch
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this to start a discussion. Unsure if this is the right change since we needed
var client = clientin quite a few places. Also needed to change all convenience methods for the concrete client onHTTPto be concrete since aninoutargument cannot have a default value.Resolves #45