Skip to content

Fix dnsNames in ace cert for acme #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnobKumarSaha merged 1 commit into from
Mar 24, 2026
Merged

Fix dnsNames in ace cert for acme #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions charts/ace-installer-certified-crds/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# ACE Installer
# ace-installer-certified-crds

[ACE Installer](https://github.com/appscode-cloud/installer) - ACE Installer
[ace-installer-certified-crds](https://github.com/appscode-cloud/installer) - ACE Installer

## TL;DR;

```bash
$ helm repo add appscode https://charts.appscode.com/stable/
$ helm repo update
$ helm search repo appscode/ace-installer --version=v2026.3.30
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
$ helm search repo appscode/ace-installer-certified-crds --version=2026.3.30
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30
```

## Introduction
Expand All @@ -21,10 +21,10 @@ This chart deploys charts for ACE on a [Kubernetes](http://kubernetes.io) cluste

## Installing the Chart

To install/upgrade the chart with the release name `ace-installer`:
To install/upgrade the chart with the release name `ace-installer-certified-crds`:

```bash
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30
```

The command deploys charts for ACE on the Kubernetes cluster in the default configuration. The [configuration](#configuration) section lists the parameters that can be configured during installation.
Expand All @@ -33,17 +33,17 @@ The command deploys charts for ACE on the Kubernetes cluster in the default conf

## Uninstalling the Chart

To uninstall the `ace-installer`:
To uninstall the `ace-installer-certified-crds`:

```bash
$ helm uninstall ace-installer -n kubeops
$ helm uninstall ace-installer-certified-crds -n kubeops
```

The command removes all the Kubernetes components associated with the chart and deletes the release.

## Configuration

The following table lists the configurable parameters of the `ace-installer` chart and their default values.
The following table lists the configurable parameters of the `ace-installer-certified-crds` chart and their default values.

| Parameter | Description | Default |
|-------------------------------------------------------|----------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Expand Down Expand Up @@ -149,12 +149,12 @@ The following table lists the configurable parameters of the `ace-installer` cha
Specify each parameter using the `--set key=value[,key=value]` argument to `helm upgrade -i`. For example:

```bash
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --set image.proxies.appscode=r.appscode.com
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30 --set image.proxies.appscode=r.appscode.com
```

Alternatively, a YAML file that specifies the values for the parameters can be provided while
installing the chart. For example:

```bash
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --values values.yaml
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30 --values values.yaml
```
22 changes: 11 additions & 11 deletions charts/ace-installer-certified/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# ACE Installer
# ace-installer-certified

[ACE Installer](https://github.com/appscode-cloud/installer) - ACE Installer
[ace-installer-certified](https://github.com/appscode-cloud/installer) - ACE Installer

## TL;DR;

```bash
$ helm repo add appscode https://charts.appscode.com/stable/
$ helm repo update
$ helm search repo appscode/ace-installer --version=v2026.3.30
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
$ helm search repo appscode/ace-installer-certified --version=2026.3.30
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30
```

## Introduction
Expand All @@ -21,10 +21,10 @@ This chart deploys charts for ACE on a [Kubernetes](http://kubernetes.io) cluste

## Installing the Chart

To install/upgrade the chart with the release name `ace-installer`:
To install/upgrade the chart with the release name `ace-installer-certified`:

```bash
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30
```

The command deploys charts for ACE on the Kubernetes cluster in the default configuration. The [configuration](#configuration) section lists the parameters that can be configured during installation.
Expand All @@ -33,17 +33,17 @@ The command deploys charts for ACE on the Kubernetes cluster in the default conf

## Uninstalling the Chart

To uninstall the `ace-installer`:
To uninstall the `ace-installer-certified`:

```bash
$ helm uninstall ace-installer -n kubeops
$ helm uninstall ace-installer-certified -n kubeops
```

The command removes all the Kubernetes components associated with the chart and deletes the release.

## Configuration

The following table lists the configurable parameters of the `ace-installer` chart and their default values.
The following table lists the configurable parameters of the `ace-installer-certified` chart and their default values.

| Parameter | Description | Default |
|-------------------------------------------------------|----------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Expand Down Expand Up @@ -149,12 +149,12 @@ The following table lists the configurable parameters of the `ace-installer` cha
Specify each parameter using the `--set key=value[,key=value]` argument to `helm upgrade -i`. For example:

```bash
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --set image.proxies.appscode=r.appscode.com
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30 --set image.proxies.appscode=r.appscode.com
```

Alternatively, a YAML file that specifies the values for the parameters can be provided while
installing the chart. For example:

```bash
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --values values.yaml
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30 --values values.yaml
```
4 changes: 4 additions & 0 deletions charts/ace/templates/gateway/route-nats.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ spec:
- group: ""
kind: Secret
name: {{ include "ace.fullname" . }}-cert
{{ if eq (index .Values "global" "platform" "hostType") "ip" }}
hostname: {{ include "ace.fullname" . }}-nats
{{- else }}
hostname: {{ .Values.global.platform.host }}
{{- end }}

---
apiVersion: gateway.networking.k8s.io/v1alpha2
Expand Down
2 changes: 2 additions & 0 deletions charts/ace/templates/ingress/certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@ spec:
kind: Issuer
name: {{ include "ace.fullname" . }}
dnsNames:
{{ if eq (index .Values "global" "platform" "hostType") "ip" }}
- {{ include "ace.fullname" . }}-nats
- {{ include "ace.fullname" . }}-nats.{{ .Release.Namespace }}.svc
- {{ include "ace.fullname" . }}-nats.{{ .Release.Namespace }}.svc.cluster.local
- {{ include "ace.fullname" . }}-s3proxy
- {{ include "ace.fullname" . }}-s3proxy.{{ .Release.Namespace }}.svc
- {{ include "ace.fullname" . }}-s3proxy.{{ .Release.Namespace }}.svc.cluster.local
{{- end }}
{{- if eq .Values.global.platform.hostType "domain" }}
- "{{ .Values.global.platform.host }}"
{{- if and .Values.nats.enabled .Values.nats.nats.externalAccess }}
Expand Down
6 changes: 3 additions & 3 deletions charts/ace/templates/ingress/issuer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ spec:
parentRefs:
- group: gateway.networking.k8s.io
kind: Gateway
name: {{ include "ace.fullname" . }}
namespace: {{ .Release.Namespace }}
sectionName: api
name: {{ include "ace.fullname" . }}-gw-seed-backend
namespace: {{ .Release.Namespace }}-gw
sectionName: http
{{- else }}
ingress:
ingressClassName: {{ index .Values "ingress-nginx" "controller" "ingressClassResource" "name" }}
Expand Down
2 changes: 1 addition & 1 deletion charts/s3proxy/templates/httproute.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ spec:
- group: ""
kind: Secret
name: {{ include "ace.fullname" . }}-cert
hostname: {{ include "ace.fullname" . }}-s3proxy
hostname: {{ index .Values.gateway.hosts 0 }}
{{- end }}

---
Expand Down
Loading