fix: Product menu remains in active state after dropdown is closed#2675
fix: Product menu remains in active state after dropdown is closed#2675ooye-sanket wants to merge 1 commit intoappwrite:mainfrom
Conversation
fix: Products menu remaining active after dropdown closes Used !text-accent to ensure proper specificity when dropdown is open Added transition-colors for smooth color transitions Ensures active state properly clears when dropdown closes Fixes #11029
WalkthroughThis change modifies the styling of the ProductsSubmenu component button element. The modification reorders focus and hover Tailwind utility classes and adds a Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Fixes the bug where the "Products" navigation menu item remains in its active (red) state after the dropdown is closed and the mouse is moved away from the menu item.
Changes made:
ProductsSubmenu.svelteto use!text-accentfor proper CSS specificity when dropdown is opentransition-colorsutility class for smooth color transitions between states$openstate becomes falseTest Plan
Steps to verify the fix:
Additional test cases:
Related PRs and Issues
Closes #11029 [https://github.com/appwrite/appwrite/issues/11029]
Screenshots
Before fix:
(The Products menu remains red after closing dropdown)
After fix:
(The Products menu returns to default color after closing dropdown)
Screenshots
Have you read the Contributing Guidelines on issues?
Yes, I have read and followed the Contributing Guidelines.