Skip to content

[WIP] BB-3812 Require ADMIN permission for SecurityAdmin CSV import endpoints #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AlexArchiPro wants to merge 1 commit into
base: 3
Choose a base branch
from
Draft

[WIP] BB-3812 Require ADMIN permission for SecurityAdmin CSV import endpoints #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions code/SecurityAdmin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace SilverStripe\Admin;

use SilverStripe\CMS\Controllers\CMSMain;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\GridField\GridFieldConfig;
use SilverStripe\Forms\GridField\GridFieldImportButton;
Expand Down Expand Up @@ -86,6 +87,10 @@ public function getManagedModels()
*/
public function ImportForm()
{
// Limit import to admin since the import logic can affect assigned permissions
if (!Permission::check('ADMIN')) {
return false;
}
$form = parent::ImportForm();
if (!$form) {
return $form;
Expand Down Expand Up @@ -113,6 +118,15 @@ public function ImportForm()
return $form;
}

public function import(array $data, Form $form): HTTPResponse
{
// Limit import to admin since the import logic can affect assigned permissions
if (!Permission::check('ADMIN')) {
$this->httpError(403);
}
return parent::import($data, $form);
}

protected function getGridFieldConfig(): GridFieldConfig
{
$config = parent::getGridFieldConfig();
Expand Down