Fix Stripes preset: strict equality for auto-position suppression, suppress auto-computed hints#129
Draft
Fix Stripes preset: strict equality for auto-position suppression, suppress auto-computed hints#129
Conversation
✅ Deploy Preview for hd-gradients ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
…ion, clean first stop, skip auto hints Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix identified issue with measurable success criteria
Fix Stripes preset: strict equality for auto-position suppression, suppress auto-computed hints
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stripes (and Neon Stripe) gradient presets generated incorrect CSS output — missing span end positions (
#000 0%instead of#000 0% 20%) and including noisy auto-computed midpoint hints — causing stripes to render as solid black.Root causes
==) for auto-position suppression —String(p1) == String(s.auto)coerced the explicit string'0'(from presetposition1: '0') to equal the auto-computed number0, stripping the start of spans.#0ff 0% 12%became#0ff 12%.0%leaked onto the first stop — a no-position leading stop (e.g.,{color: '#fff'}) gotposition1=0, position2=0fromupdateStops; onlyp1was suppressed, leaving an unwanted trailing0%.isPctZerostripped the0%span start — no guard for the presence ofp2, so a stop like{position1: '0', position2: '12'}had its0%incorrectly removed.Gradient.svelteincluded auto-computed hints — the localstopsToStringswas missing the same midpoint-hint suppression thatgradientString.tsalready had.Changes
src/utils/gradientString.ts:p1 === s.auto(strict) replacesString(p1) == String(s.auto);isPctZeroonly strips when nop2exists; suppresses auto-assignedp2on the first stop whenp1was also auto-suppressed.src/components/Gradient.svelte(stopsToStrings): Same strict-equality fix and first-stopp2suppression; addss.percentage == s.autoguard to skip auto-computed midpoint hints.Before / after for the Stripes preset:
src/lib/roundtrip.test.ts: Two new test cases usingstopWithAuto/hintWithAutohelpers that simulate realupdateStopsoutput — covering the clean first-stop case and the preserved explicit span case.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.