fix(pds): serve atproto-did for custom handles#152
Open
rudraksha-avatar wants to merge 2 commits intoascorbic:mainfrom
Open
fix(pds): serve atproto-did for custom handles#152rudraksha-avatar wants to merge 2 commits intoascorbic:mainfrom
rudraksha-avatar wants to merge 2 commits intoascorbic:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
This addresses #145.
The previous hostname check caused handle verification to fail for valid routed did:web deployments where the handle domain and PDS hostname are intentionally different.
I could not run the normal pnpm test flow in this environment because pnpm is not installed here, but the change is covered with a focused test.