Skip to content

feat: add support for React 19#54

Merged
askides merged 2 commits intoaskides:mainfrom
j0nas:feat/react-19-support
Mar 6, 2025
Merged

feat: add support for React 19#54
askides merged 2 commits intoaskides:mainfrom
j0nas:feat/react-19-support

Conversation

@j0nas
Copy link

@j0nas j0nas commented Feb 26, 2025

Closes #53.

Also, thank you for a pretty darn cool library. 🤙

@vercel
Copy link
Contributor

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-plock-with-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:26am
react-plock-with-vite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:26am

@askides
Copy link
Owner

askides commented Feb 28, 2025

Hi @j0nas, please be sure to update the lockfile as well running a pnpm install, otherwise the installation will fail.

@j0nas
Copy link
Author

j0nas commented Feb 28, 2025

Hi @j0nas, please be sure to update the lockfile as well running a pnpm install, otherwise the installation will fail.

Silly me. I didn't see a package-lock.json, so I assumed it wasn't necessary. I didn't see a packageManager field in the package.json so I didn't consider that other package managers could be in play. Is the omission of a packageManager field deliberate? pnpm automatically adds it, so I've kept it in 02e914a but let me know if you don't want it.

@j0nas
Copy link
Author

j0nas commented Mar 4, 2025

@askides Anything else I can contribute with here?

@askides
Copy link
Owner

askides commented Mar 6, 2025

@j0nas fine. Gonna merge, TY.

@askides askides merged commit e49c38e into askides:main Mar 6, 2025
4 checks passed
@j0nas j0nas deleted the feat/react-19-support branch March 6, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for React 19

2 participants