fix: incorrect typing speed unit of computer type tool#272
fix: incorrect typing speed unit of computer type tool#272philipph-askui wants to merge 1 commit intomainfrom
Conversation
…s per minute to characters per second
philipph-askui
changed the title
| "description": ( | ||
| "The speed of typing in characters per minute." | ||
| "The speed of typing in characters per second." | ||
| " Defaults to 50" |
There was a problem hiding this comment.
@programminx-askui should we increase the default value?
There was a problem hiding this comment.
Would be nice, if we could set the default as a a config value so that it can be easily set per project. For example when operating a VNC window, a too high typing speed will lead to some characters being not typed....
There was a problem hiding this comment.
Since the agent can modify the value, even changing the default doesn’t guarantee it will be used.
btw, are you sure that the value is per second ?
There was a problem hiding this comment.
The agent usually does not modify the value unless it is specifically prompted to do so. Also, it would make more sense to set it once for these specific scenarios so that the agent does not need to do it for every type call. However, this is a low priority issue in my opinion so I would not add it to this PR for now.
There was a problem hiding this comment.
I have the feeling something is off. And either the typeing speed in the API, the gloabl config is not working or the Agent is randomly changing the speed which leads in chars which are not recognized by the application.
We need first to do a proper testing, but I woul do it in another bug ticket.
There was a problem hiding this comment.
It seems to work as expected on mac, so this might be a windows issue?
There was a problem hiding this comment.
Anyways, the descriptions should be changed from minutes to seconds (as done in this PR) in order to align with the definition of the API.
3 participants
the description stated that typing speed was character per minute, in fact, the parameter controls the typing speed in characters per second.