Skip to content

fix: updated dependencies issue#1836#1936

Closed
sarthakNITT wants to merge 3 commits intoasyncapi:masterfrom
sarthakNITT:issue#1929_2
Closed

fix: updated dependencies issue#1836#1936
sarthakNITT wants to merge 3 commits intoasyncapi:masterfrom
sarthakNITT:issue#1929_2

Conversation

@sarthakNITT
Copy link
Copy Markdown
Contributor

@sarthakNITT sarthakNITT commented Dec 19, 2025

issue #1836
Description

  • Updated rimraf, unzipper, mocha, and @stoplight/spectral-cli to their latest versions to fix direct deprecation warnings.
  • Migrated test coverage from nyc (which relied on deprecated glob/rimraf) to c8.

Note -
Remaining deprecation warnings during install are transitive dependencies from @asyncapi/generator and @asyncapi/modelina-cli. These packages need to be updated in their respective repositories to fully resolve the warnings.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 19, 2025

⚠️ No Changeset found

Latest commit: 76a6a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud
Copy link
Copy Markdown

@sarthakNITT
Copy link
Copy Markdown
Contributor Author

@Shurtu-gal Review this pr once. To resolve the remaining warnings for the packages listed in the issue, we need to update dependencies in:

@asyncapi/generator: Fixes readdir-scoped-modules, read-package-json, debuglog, npmlog, are-we-there-yet, gauge, @npmcli/move-file, mkdirp, and @asyncapi/generator-hooks.
@asyncapi/modelina-cli: Fixes @oclif/errors.

@Shurtu-gal
Copy link
Copy Markdown
Collaborator

@sarthakNITT there is another PR already in place for the same issue. Was there any reason a new PR had to be opened instead of suggesting changes in the original one or just collaborating there?

@sarthakNITT
Copy link
Copy Markdown
Contributor Author

sarthakNITT commented Dec 22, 2025

@Shurtu-gal Sorry for the confusion. I reviewed the existing PR, but it included multiple changes beyond what I was planning to address for this issue. To keep the scope focused and make the review easier, I decided to open a clean PR with only the relevant changes. Now I have added required suggestion in the existing pr.

@Shurtu-gal
Copy link
Copy Markdown
Collaborator

Closing this as the other has been merged.

@Shurtu-gal Shurtu-gal closed this Jan 7, 2026
@github-project-automation github-project-automation Bot moved this from To Triage to Done in CLI - Kanban Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants