fix: add python_requires='>=3.9' to prevent install on Python 3.8 #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current release (4.x) utilizes PEP 585 Generic Alias Types (e.g.,
dict[Any, Any]), which were introduced in Python 3.9.When installing this package on a Python 3.8 environment,
pipcurrently pulls the latest version becausesetup.pyis missing thepython_requiresconstraint. This leads to an immediate runtime crash:TypeError: 'type' object is not subscriptable.Solution
This PR adds
python_requires='>=3.9'tosetup.py.Benefit
This ensures that
pipon older environments (Python 3.8 and below) will correctly ignore the incompatible 4.x releases and automatically fall back to the last compatible version (3.x), preventing broken builds for users on legacy systems.