Add configurable click geometry options#78
Draft
jamesmontemagno wants to merge 1 commit into
Draft
Conversation
|
@jamesmontemagno is attempting to deploy a commit to the Aurora Scharff's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concept for more customization of the click events. Let me know thoughts.
This pull request introduces customizable geometry shapes for mouse click pulses, allowing users to select different shapes for each click type (left, right, middle, and drag) in the ClickLight app. The changes span the settings model, UI, and rendering logic to support and display these new customization options.
Geometry Shape Customization
ClickSettingsandClickProfileSettingsfor the shape of each click type, with sensible defaults for each (e.g., ring for left click, cross for right click, diamond for middle click, dot for drag). [1] [2] [3]geometryShape(for:)method inClickSettingsto retrieve the appropriate shape for each click kind, and aresetGeometryToDefaults()method to restore default shapes. [1] [2]Settings UI Enhancements
ClickLightSettingsView) with a new "Geometry" section, allowing users to pick a shape for each click type via a picker, and added a "Reset Geometry" button.Rendering Logic Updates
ClickOverlayView) to use the selected geometry shape for each click pulse, replacing hardcoded shape drawing calls with a newdrawShapemethod. [1] [2] [3] [4] [5] [6] [7]Profile Persistence
ClickProfileSettings. [1] [2]These changes collectively provide users with flexible visual customization for click feedback, improving both accessibility and personalization.
Test Plan
./build-app.shChecklist
TinyClips.2026-06-09.at.23.36.32.mp4