Fix: Bad request error when no email provider is configured#1321
Open
ankita10119 wants to merge 2 commits intomasterfrom
Open
Fix: Bad request error when no email provider is configured#1321ankita10119 wants to merge 2 commits intomasterfrom
ankita10119 wants to merge 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1321 +/- ##
=======================================
Coverage 80.15% 80.16%
=======================================
Files 152 152
Lines 6088 6089 +1
Branches 1243 1244 +1
=======================================
+ Hits 4880 4881 +1
Misses 693 693
Partials 515 515 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kushalshit27
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Added a guard in
emailProvider.ts to short-circuit the delete/update logic when no existing provider is present (!existing.name). If there's nothing to delete, we return early and skip the API call entirely.🔬 Testing
Added a test case covering the scenario where emailProvider is empty,
AUTH0_ALLOW_DELETEis true, and no existing provider exists - asserting that neither update nor create are called.📝 Checklist