Skip to content

Fix typo: 'thumprints' to 'thumbprints' in signers.js #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ForbesLindesay wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo: 'thumprints' to 'thumbprints' in signers.js #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/signers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ module.exports.validateXmlEmbeddedSignature = function (xml, options) {
return ['Signature is missing'];
}

if (options.thumprints){
// Make sure thumprints is an array for the validation
if (options.thumbprints){
// Make sure thumbprints is an array for the validation
options.thumbprints = options.thumbprints instanceof Array ? options.thumbprints : [options.thumbprints];
}

Expand All @@ -79,7 +79,7 @@ module.exports.validateXmlEmbeddedSignature = function (xml, options) {
return certToPEM(options.signingCert);
}

//If there's an embedded signature and thumprints are provided check that
//If there's an embedded signature and thumbprints are provided check that
if (options.thumbprints && options.thumbprints.length > 0) {
var embeddedSignature = keyInfo[0].getElementsByTagNameNS("http://www.w3.org/2000/09/xmldsig#", "X509Certificate");
if (embeddedSignature.length > 0) {
Expand All @@ -92,7 +92,7 @@ module.exports.validateXmlEmbeddedSignature = function (xml, options) {
}
}

// If there's an embedded signature, but no thumprints are supplied, use options.cert
// If there's an embedded signature, but no thumbprints are supplied, use options.cert
// either options.cert or options.thumbprints must be specified so at this point there
// must be an options.cert
return certToPEM(options.signingCert);
Expand Down